[Relax][Bugfix] Bind symbolic variables in R.match_cast #17023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, variable replacement by `BindSymbolicVars` would fail to replace variables that occur within a `relax::MatchCast` node. This pattern is rare, because the `bind_symbolic_vars` method can only replace variables that are exposed as part of the function signature, and most uses of `relax::MatchCast` act as a definition for symbolic variables that are not exposed through the function signature. This pattern is well-formed, though, since the `relax::MatchCast` node can also act as a user of previously-defined symbolic variables. The root cause for this bug was in the `ExprMutator` visitor for `relax::MatchCast`, which did not visit the struct info field. As a result, the virtual `ExprMutator::VisitPrimExpr` function was not called for expressions that occur within the `StructInfo` of a `relax::MatchCast`. This commit updates `ExprMutator` to resolve this bug, and applies an analogous fix for `ExprVisitor`. Co-authored-by: Chris Sullivan <csullivan@octoml.ai>
tqchen
approved these changes
May 24, 2024
|
Closing to resubmit as a new PR (same issue as mentioned here), due to CI issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, variable replacement by
BindSymbolicVarswould fail to replace variables that occur within arelax::MatchCastnode. This pattern is rare, because thebind_symbolic_varsmethod can only replace variables that are exposed as part of the function signature, and most uses ofrelax::MatchCastact as a definition for symbolic variables that are not exposed through the function signature. This pattern is well-formed, though, since therelax::MatchCastnode can also act as a user of previously-defined symbolic variables.The root cause for this bug was in the
ExprMutatorvisitor forrelax::MatchCast, which did not visit the struct info field. As a result, the virtualExprMutator::VisitPrimExprfunction was not called for expressions that occur within theStructInfoof arelax::MatchCast. This commit updatesExprMutatorto resolve this bug, and applies an analogous fix forExprVisitor.